Skip to content

Agency support - #108

Merged
otc-zuul[bot] merged 6 commits into
masterfrom
credential
Sep 22, 2020
Merged

Agency support#108
otc-zuul[bot] merged 6 commits into
masterfrom
credential

Conversation

@gtema

@gtema gtema commented Sep 15, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@gtema
gtema requested a review from vladimirhasko September 16, 2020 09:07
otc-zuul[bot]
otc-zuul Bot previously approved these changes Sep 16, 2020

return 'assume_role', agency

def get_cache_id_elements(self):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this method about?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the keystoneauth interface to enable "authorization caching"

}
body = {'auth': {'identity': {}}}
ident = body['auth']['identity']
rkwargs = {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of rkwargs?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from existing pwd authorization. Not really used. Let's cleanup in a followup

@tischrei

Copy link
Copy Markdown
Member

I stop development in the credential due to the fact this PR is existing (didn't notice it ). So review can be finished.

@gtema gtema added the gate label Sep 22, 2020
@otc-zuul

otc-zuul Bot commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

Build succeeded.

@otc-zuul
otc-zuul Bot merged commit 2a0a39a into master Sep 22, 2020
@gtema
gtema deleted the credential branch November 23, 2020 08:16
vineet-pruthi pushed a commit to fkukucsk/python-otcextensions that referenced this pull request Nov 30, 2023
Agency support

Reviewed-by: Artem Goncharov <Artem.goncharov@gmail.com>
             https://github.com/gtema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants