Conversation
tischrei
requested changes
Mar 12, 2020
tischrei
left a comment
tischrei
left a comment
Member
There was a problem hiding this comment.
Hi Vineet, I have commented several smaller sections. I am not able to review the functional tests because I have never done those. Have you checked everything manually?
tischrei
previously approved these changes
Mar 18, 2020
Collaborator
|
recheck |
Contributor
|
Build succeeded (check pipeline).
|
tischrei
approved these changes
Mar 25, 2020
vladimirhasko
approved these changes
Mar 25, 2020
vladimirhasko
previously approved these changes
Mar 25, 2020
tischrei
previously approved these changes
Mar 25, 2020
gtema
requested changes
Mar 25, 2020
gtema
left a comment
gtema
left a comment
Collaborator
There was a problem hiding this comment.
While there are lots of typos - the crucial required change is rebase to current master, since you will drop some later changes in otcextensions/sdk/init.py
vineet-pruthi
dismissed stale reviews from tischrei and vladimirhasko
via
March 26, 2020 09:53
1cab5eb
gtema
requested changes
Apr 2, 2020
gtema
left a comment
gtema
left a comment
Collaborator
There was a problem hiding this comment.
need to carefully look at func tests again - cleanup is not working properly
Collaborator
|
recheck |
Contributor
|
Build failed.
|
Collaborator
|
recheck |
Contributor
|
Build succeeded.
|
gtema
requested changes
Apr 8, 2020
Collaborator
|
recheck |
gtema
approved these changes
Apr 14, 2020
Collaborator
|
/merge |
vineet-pruthi
added a commit
to fkukucsk/python-otcextensions
that referenced
this pull request
Nov 30, 2023
* initial nat gateway branche * added snat and dnat resource * dnat and snat proxy functions added * first running state * gateway fixed * linting corrections * Minor changes, tested successfully * unittest nat.test_snat nat.test_dnat and nat.test_gateway added * nat changes * pep8 issues * test_proxy.py added for NAT * stash status changed and proxy test added * Adding osclient code for nat * Adding osclient code for nat * Fixed error and adding unit tests for osclient * Fixed error and adding unit tests for osclient * Minor fix in unit test * Minor fix in unit test * Adding functional tests for nat_gateway * Adding functional tests for nat_gateway * Adding some more functional tests for nat * Updated documentation for NAT * Fixed nat.rst erros * initial nat gateway branche * added snat and dnat resource * first running state * gateway fixed * linting corrections * Minor changes, tested successfully * nat changes * Updated Functional Tests * Usage of project_id in list nat functions query params * Updated nat_gateway_id as keyword arg * remove python2 dependancy from tox * Updated args for show delete and update for NAT * Updated travis.yml to skip py27 and include py37 * Fixed unit tests with updated args * roll back py27 in tox.ini * Fixed errors and remove nat documentation" * Removed print * initial nat gateway branche * Adding osclient code for nat * Adding osclient code for nat * Fixed error and adding unit tests for osclient * Fixed error and adding unit tests for osclient * Minor fix in unit test * Adding functional tests for nat_gateway * Adding some more functional tests for nat * Updated documentation for NAT * Fixed nat.rst erros * Updated Functional Tests * Usage of project_id in list nat functions query params * Updated nat_gateway_id as keyword arg * remove python2 dependancy from tox * Fixed unit tests with updated args * roll back py27 in tox.ini * Fixed errors and remove nat documentation" * Removed print * Checkout origin/master otcextensions/sdk/__init__.py * Formatting Fixes and raise error if nat gateway not found * Fixed osclient Unit Tests for nat * Fixed docstring for nat fakes.py * Updated osclient functional tests for nat * Fixes in Functional Tests * Updated Line breaks for help * Added multiple delete support * Fixed resource cleanup issue * checkout doc/source/cli/index.rst with origin/master * Adding NAT doc * Minor correction * Updated functional Tests * fix for newer Sphinx * do not append project_id in the nat service Co-authored-by: T. Schreiber <tino.schreiber@t-systems.com> Co-authored-by: Artem Goncharov <Artem.goncharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.