Extend DMS to cover Kafka Premium extensions - #76
Merged
Merged
Conversation
gtema
force-pushed
the
dms
branch
2 times, most recently
from
April 17, 2020 14:52
43bbdba to
cea9c69
Compare
Contributor
|
Build failed.
|
Collaborator
Author
|
recheck |
Contributor
|
Build succeeded.
|
Contributor
|
Build succeeded.
|
Contributor
|
Build succeeded.
|
Contributor
|
Build succeeded.
|
Contributor
|
Build succeeded.
|
Contributor
|
Build failed.
|
|
|
||
| return self | ||
|
|
||
| def ack(self, session, queue_obj, ids, status='success'): |
Member
There was a problem hiding this comment.
this way we limit all messages only to 1 status value.
Isn't there possibility to address pairs of messages and statuses?
| from otcextensions.sdk.dms.v1 import _base | ||
|
|
||
|
|
||
| class Instance(_base.Resource): |
Member
There was a problem hiding this comment.
action method not defined for restart or batch delete functions?
| 'include_messages_num' | ||
| ) | ||
|
|
||
| # Properties |
Member
There was a problem hiding this comment.
what about max_msg_size_byte, reservation, produced_messages, group_count, eff_date, kafka_topic parameters?
vladimirhasko
left a comment
vladimirhasko
left a comment
Member
There was a problem hiding this comment.
I've reviewed SDK so far (except unit tests)
will look on unit later tomorrow
Contributor
|
Build failed.
|
Contributor
|
Build failed.
|
Adding basic functional test for DMS instance Reviewed-by: https://github.com/apps/otc-zuul
vladimirhasko
self-requested a review
May 4, 2020 06:34
vladimirhasko
approved these changes
May 4, 2020
Collaborator
Author
|
recheck |
Contributor
|
Build failed.
|
Collaborator
Author
|
recheck |
Contributor
|
Build succeeded.
|
vladimirhasko
self-requested a review
May 4, 2020 07:39
vladimirhasko
approved these changes
May 4, 2020
Collaborator
Author
|
/merge |
Contributor
|
Build succeeded.
|
vineet-pruthi
pushed a commit
to fkukucsk/python-otcextensions
that referenced
this pull request
Nov 30, 2023
Extend DMS to cover Kafka Premium extensions Reviewed-by: https://github.com/apps/otc-zuul
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.