DCS fixes - #86
Merged
Merged
Conversation
Member
Author
|
/recheck |
Collaborator
|
recheck |
Contributor
|
Build failed.
|
Member
Author
|
recheck |
2 similar comments
Contributor
|
recheck |
Member
Author
|
recheck |
Contributor
|
Build failed.
|
Member
Author
|
recheck |
Contributor
|
Build succeeded.
|
vineet-pruthi
approved these changes
Jul 28, 2020
| return self._update(_tracker.Tracker, tracker, **attrs) | ||
|
|
||
| def delete_tracker(self, tracker, ignore_missing=True): | ||
| def delete_tracker(self, tracker='system', ignore_missing=True): |
Contributor
There was a problem hiding this comment.
the function should-- returns: None and no rtype: required
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| """ | ||
| Extend a Distributed Message Service Instance with additional RAM |
Contributor
There was a problem hiding this comment.
Distributed Cache Service
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| """ | ||
| Find Distributed Message Service Instance by id or name |
Contributor
There was a problem hiding this comment.
Distributed Cache Service
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| """ | ||
| List all Backups of a Distributed Message Service instance |
Contributor
There was a problem hiding this comment.
Distributed Cache Service
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| """ | ||
| List all Restore Records of a Distributed Message Service instance |
Contributor
There was a problem hiding this comment.
Distributed Cache Service
|
|
||
| :param zone: The value can be the ID of a zone | ||
| or a :class:`~otcextensions.sdk.dns.v2.zone.Zone` instance. | ||
| :param router: The parameter router_id is mandatory |
| instance_id=inst.id, **query) | ||
|
|
||
| def delete_instance_backup(self, backup, ignore_missing=True, **attrs): | ||
| def delete_instance_backup(self, instance, backup, ignore_missing=True, |
Contributor
There was a problem hiding this comment.
- No description about param instance provided in docstring.
- Wrong description for param backup.
- No description about dictionary param attrs given, does the delete method really required additional attrs ?
| } | ||
| name_or_id = 'configuration_name_or_id' | ||
| configuration = conn.rds.find_configuration(name_or_id=name_or_id) | ||
| configuration = conn.rds.create_configuration(config=configuration, |
Contributor
There was a problem hiding this comment.
shouldn't it be update_configuration ?
| conn = openstack.connect(cloud='otc') | ||
|
|
||
| instance = 'instance_id' | ||
| policy = conn.rds.get_instance_backup_policy(instance) |
Contributor
There was a problem hiding this comment.
set_instance_backup_policy
Contributor
|
/merge |
Contributor
|
Build failed.
|
Contributor
|
recheck |
Contributor
|
Build failed.
|
Contributor
|
recheck |
Contributor
|
Build failed.
|
Contributor
|
recheck |
Contributor
|
Build succeeded.
|
Contributor
|
/merge |
Contributor
|
Build failed.
|
Contributor
|
/merge |
Contributor
|
Build succeeded.
|
vineet-pruthi
pushed a commit
to fkukucsk/python-otcextensions
that referenced
this pull request
Nov 30, 2023
DCS fixes Reviewed-by: https://github.com/apps/otc-zuul
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.