Make instant seal work and added interval#2589
Merged
l0r1s merged 7 commits intoMay 5, 2026
Merged
Conversation
girazoki
changed the title
…-instant-seal-work-and-added-interval
evgeny-s
added
the
skip-cargo-audit
l0r1s
approved these changes
May 5, 2026
Collaborator
l0r1s
left a comment
l0r1s
left a comment
There was a problem hiding this comment.
Added a small comment, not sure if it changes anything in our case though.
| Sealing::Manual => Box::pin(commands_stream), | ||
| Sealing::Instant => Box::pin(transaction_pool.import_notification_stream().map(|_| { | ||
| sc_consensus_manual_seal::rpc::EngineCommand::SealNewBlock { | ||
| create_empty: false, |
Collaborator
There was a problem hiding this comment.
Original behavior is create_empty: true for instant seal, should we preserve this?
There was a problem hiding this comment.
that was the reason why it wasnt working from what I had seen, but I did not dig too much into the issue. When you think about it instant means "as soon as there is a transaction" which by default means a non-empty block. before this PR this was not working but now is
open-junius
approved these changes
May 5, 2026
Contributor
open-junius
left a comment
open-junius
left a comment
There was a problem hiding this comment.
verified the command, it works. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Instant seal which was not working because
consensus_providerswere not being passed and also adds interval sealing, which will create a block at the defined interval.Instant sealing works better when offchain workers are disabled, as the offchain worker creates txs by itself.
Example usages:
./target/release/node-subtensor --dev --tmp --sealing=instant --offchain-worker never./target/release/node-subtensor --dev --tmp --sealing=6000More flexibility when testing
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.