Fix another regression caused by #609 (for develop).#646
Merged
pstaabp merged 1 commit intoFeb 6, 2022
Merged
Conversation
If a problem sets the answer to be a formula with an assigment,
(something like `Formula("x = 5")` then all answers are counted
incorrect and a warning is displayed that the evaluated answer is not an
answer hash. This worked prior to openwebwork#609. The cause of this was the
removal of a line that should not have been removed that converts the
other answer being compared to to a Formula if it is not already.
Note that the original issue that was attempted to be fixed by openwebwork#609
still is fixed with this change.
This fixes issue openwebwork#644 that I just submitted about this.
pstaabp
approved these changes
Feb 1, 2022
pstaabp
left a comment
pstaabp
left a comment
Member
There was a problem hiding this comment.
This does seem to fix this error and I did look back in the history and see that the line you added is restored.
drdrew42
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a problem sets the answer to be a formula with an assigment, (something like
Formula("x = 5")then all answers are countedincorrect and a warning is displayed that the evaluated answer is not an answer hash. This worked prior to #609. The cause of this was the removal of a line that should not have been removed that converts the other answer being compared to to a Formula if it is not already.
Note that the original issue that was attempted to be fixed by #609 still is fixed with this change.
This fixes issue #644 that I just submitted about this.
This is #645 for develop.