Remove reducedScoring from PG.

[somiaj]

As discussed in #648 PG should report raw scores to webwork, and webwork should then adjust the score accordingly. This removes all reducedScoring computations from PG and the variable sub_recorded_score will no longer be set by PG, thus PG will only return the record_score to webwork.

This needs to be merged with openwebwork/webwork2#1578.

[somiaj]

It appears that reduced scoring is also included in some problems inside the OPL. grep -r sub_recorded_score returns various files that are using reduced scoring that will also need to be updated to remove reduced scoring from PG. The file list I get is:

Contrib/CUNY/CityTech/Precalculus/setVectors_-_Magnitude_and_Direction/ggb-magnitude-direction.pg
Contrib/CUNY/CityTech/Precalculus/setVectors_-_Components/ggb-vector-components.pg
Contrib/CUNY/CityTech/Precalculus/setVectors_-_Components/ggb-unit-vector-components.pg
Contrib/CUNY/CityTech/Precalculus/setVectors_-_Unit_Vectors/ggb-magnitude-angle.pg
Contrib/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/parabola-roots-multians-incremental.pg
Contrib/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/line-intercepts-multians-inc/line-intercepts-multians-inc.pg
Contrib/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/circle-center-multians-inc/circle-center-multians-inc-test.pg
Contrib/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/circle-center-multians-inc/circle-center-multians-inc.pg
Pending/CUNY/CityTech/Precalculus/setVectors_-_Magnitude_and_Direction/ggb-magnitude-direction.pg
Pending/CUNY/CityTech/Precalculus/setVectors_-_Components/ggb-vector-components.pg
Pending/CUNY/CityTech/Precalculus/setVectors_-_Components/ggb-unit-vector-components.pg
Pending/CUNY/CityTech/Precalculus/setVectors_-_Unit_Vectors/ggb-magnitude-angle.pg
Pending/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/parabola-roots-multians-incremental.pg
Pending/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/line-intercepts-multians-inc/line-intercepts-multians-inc.pg
Pending/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/circle-center-multians-inc/circle-center-multians-inc-test.pg
Pending/CUNY/CityTech/CollegeAlgebra_Trig/setGeogebra/circle-center-multians-inc/circle-center-multians-inc.pg

[drgrice1]

Those are all @drdrew42's problems. So ask him about those.

[drgrice1]

It looks like @drdrew42 will just need to delete the assignment to the sub_recorded_score. It shouldn't be needed for his problems. He is also assigning to the recorded_score, which should be enough. @drdrew42 is hacking on pg's internals to make those problems work.

[drdrew42]

@drgrice1 is correct, assigning values to sub_recorded_score in these problems is not necessary.

[pstaabp]

PR #709 has superseded this by removing the reducedScoring functionality from PG.

[somiaj]

Closing. Outdated and has been superseded by #709.