Docker updates 2022 07 22#4
Closed
taniwallach wants to merge 3 commits into
Closed
Conversation
there that are still needed by the standalone renderer when rendering a problem. Requests to webwork2_files are redirected as appropriate by the renderer. Most go to PG/htdocs.
(or PG-2.17 branch) of PG.
Member
|
Did you mean to target this to the develop branch? |
- 2 stage build process
- changes needed after the PG-2.17 update and the changes to
how codemirror is included.
- update build instructions and other things in README.md
taniwallach
force-pushed
the
docker-updates-2022-07-22
branch
from
71c5787 to
243e728
Compare
Member
Author
I guess so. Sorry - changed. |
Closed
Member
Author
|
Replaced by #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to make the Docker build work, and to split it into a 2 stage build, so the underlying OS packages and CPAN installs need not be redone for each rebuild of the main image.
It also updates the build instructions in
README.mdand points those also to use the openwebwork repository and not the drdrew42 repository.This PR was based off the branch with the PG-2.17 updates, so needs to be merged after #2. There is only one new commit after what is in that PR.
Note:
.gitwas removed from.dockerignoreas otherwise thenpm installinsidelib/PG/htdocsis failing.