Move OPL macros to PG#1803
Merged
Merged
Conversation
This was referenced Sep 19, 2022
dcd97a3 to
35ab83b
Compare
drgrice1
approved these changes
Oct 22, 2022
Comment on lines
+1118
to
+1127
| "$pg{directories}{macros}/answers", | ||
| "$pg{directories}{macros}/capa", | ||
| "$pg{directories}{macros}/contexts", | ||
| "$pg{directories}{macros}/core", | ||
| "$pg{directories}{macros}/graph", | ||
| "$pg{directories}{macros}/math", | ||
| "$pg{directories}{macros}/misc", | ||
| "$pg{directories}{macros}/parsers", | ||
| "$pg{directories}{macros}/ui", | ||
| "$courseDirs{templates}/Library/macros/univ", |
Member
There was a problem hiding this comment.
There seems to be an inconsistency in the indentation here. All of these lines should be at the same indent level.
Member
Author
There was a problem hiding this comment.
It was a mix of tabs and spaces. We need to do a perltidy of webwork2.
35ab83b to
0595af6
Compare
drgrice1
approved these changes
Oct 23, 2022
drgrice1
left a comment
Member
There was a problem hiding this comment.
Once openwebwork/pg#724 goes in, this is ready to go also.
a4c4136 to
fd6aae2
Compare
fd6aae2 to
1bc932a
Compare
1bc932a to
70452e9
Compare
70452e9 to
f572d05
Compare
removed macros in webwork2/doc directory
f572d05 to
a4b7823
Compare
drdrew42
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion to openwebwork/pg#724 and just updates the
defaults.configfile to point to the new locations of macros.You will need to checkout openwebwork/pg#724 and openwebwork/webwork-open-problem-library#949
An alternative to checking out the OPL branch you can set in
conf/localOverrides.confthe following:Note: there are other macros in the OPL macros directory that are not being used in the OPL. (For example, UW-Stout). These directories should be added to the above list if desired.