Skip to content

Make renaming a course or unarchiving a course to a new name work again. #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drdrew42 merged 2 commits into from
May 25, 2023
Merged

Make renaming a course or unarchiving a course to a new name work again. #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce5ce5a
Make renaming a course or unarchiving a course to a new name work again.
drgrice1 May 19, 2023
8f1cb04
Add a check for course name validity when unarchiving a course to a n…
drgrice1 May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/WeBWorK/ContentGenerator/CourseAdmin.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,10 @@ sub unarchive_course_validate ($c) {
push @errors, $c->maketext('Course ID cannot exceed [_1] characters.', $ce->{maxCourseIdLength});
}

unless ($courseID =~ /^[\w-]*$/) { # regex copied from CourseAdministration.pm
push @errors, $c->maketext('Course ID may only contain letters, numbers, hyphens, and underscores.');
}

return @errors;
}

Expand Down
6 changes: 1 addition & 5 deletions lib/WeBWorK/Utils/CourseManagement.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,11 +505,7 @@ sub renameCourse {
}

# get new course environment
my $newCE = $oldCE->new(
$oldCE->{webworkDirs}->{root},
$oldCE->{webworkURLs}->{root},
$oldCE->{pg}->{directories}->{root}, $newCourseID,
);
my $newCE = $oldCE->new({ courseName => $newCourseID });

# find the course dirs that still exist in their original locations
# (i.e. are not subdirs of $courseDir)
Expand Down