Move database and external program settings #2338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
requested changes
Feb 25, 2024
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
This needs a lot of work to be acceptable.
drgrice1
reviewed
Feb 25, 2024
drgrice1
reviewed
Feb 25, 2024
drgrice1
reviewed
Feb 26, 2024
drgrice1
reviewed
Feb 26, 2024
drgrice1
reviewed
Feb 26, 2024
drgrice1
reviewed
Feb 26, 2024
pstaabp
force-pushed
the
remove-database-conf
branch
2 times, most recently
from
1dfc58e to
efc71d0
Compare
Member
Author
|
This removes all references to dbLayoutName and cases where the dbLayouts hash is used. With this, there is only the standard dbLayout, which is now defined in Also, removed the older style unarchive database archive file. It was unclear when this was last in the codebase, probably > 10 years. |
pstaabp
force-pushed
the
remove-database-conf
branch
2 times, most recently
from
783dbb2 to
2103368
Compare
Contributor
|
Note conflicts here now from a recent merge. |
This moves database and external program settings to webwork2.mojolicious.yml, moves code from database.conf.dist to WeBWorK::DB::Utils and load these settings into the CourseEnvironment.
This removes all references to dbLayoutName and cases where the dbLayouts hash is used. With this, there is only the standard dbLayout, which is now defined in `WeBWorK::DB::Layout`.
pstaabp
force-pushed
the
remove-database-conf
branch
from
2103368 to
58fa953
Compare
Member
Author
|
Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
site.confanddefaults.configtowebwork2.mojolicious.ymldatabase.conf.disttoWeBWorK::DB::UtilsCourseEnvironment.These settings will be loaded after
simple.confandcourse.confso instructors will not be able to override these settings.