Suggestion from #3043.#3060
Merged
pstaabp merged 1 commit intoJul 14, 2026
Merged
Conversation
drgrice1
force-pushed
the
bugfix/unarchive-course-id-from-archive-addition
branch
from
b97b402 to
f2fd663
Compare
Wrap the `unarchiveCourse` call in the `do_unarchive_course` method of the `WeBWorK::ContentGenerator::CourseAdmin` package in an `eval`, so that exceptions are caught. The exceptions are already checked for on the next line, but deal with the exception message better. Instead of displaying `$@` which might include a backtrace, show `$@->message` in the case that `$@` is an object.
drgrice1
force-pushed
the
bugfix/unarchive-course-id-from-archive-addition
branch
from
f2fd663 to
757fc95
Compare
Alex-Jordan
approved these changes
Jul 14, 2026
pstaabp
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the
unarchiveCoursecall in thedo_unarchive_coursemethod of theWeBWorK::ContentGenerator::CourseAdminpackage in aneval, so that exceptions are caught. The exceptions are already checked for on the next line, but deal with the exception message better. Instead of displaying$@which might include a backtrace, show$@->messagein the case that$@is an object.This is built on top of #3043 (and rebased onto the current
WeBWorK-2.21branch). I am making a new pull request so that we can merge this (and #3043) and move on.