-
Notifications
You must be signed in to change notification settings - Fork 2.8k
luci-app-2fa: init checkin #8280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
luci-app-2fa: init checkin #8280
Conversation
This comment has been minimized.
This comment has been minimized.
|
@Tokisaki-Galaxy: Nice, good job! Do not forget to solve: |
|
Looks very polished @Tokisaki-Galaxy! Does this use TOTP? If the OpenWrt device doesn't have RTC and is offline or generally doesn't have correct time, does SSH become the only option to login? Is there a README/instructions (ideally a hint on failed attempt) on how to disable 2FA from SSH/CLI for people who may be locked out of WebUI and can't read code ahead of time? |
|
At present, we are dealing with the interface logic of interaction with luci core #8281 and the logic of app should be put aside first. At present, my rough goal is
When abnormal time is detected under TOTP, 2FA will be automatically disabled, so as to minimize the user's inability to log in and need to be manually disabled through ssh. |
d55e8c5 to
0e97b5b
Compare
This comment has been minimized.
This comment has been minimized.
0e97b5b to
fe02937
Compare
Co-authored-by: Christian Marangi <ansuelsmth@gmail.com> Signed-off-by: tokisaki galaxy <moebest@outlook.jp>
fe02937 to
bed757a
Compare
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile[POC,WIP] Implement 2-Factor Authentication with TOTP or HOTP #7069
Feature request: Support for Passkey (WebAuthn) authentication in LuCI #8273
the app must changed LuCI core file because:
Security Measures
Constant-time string comparison to prevent timing attacks
Username sanitization to prevent command injection
Array-based popen to prevent shell injection
OTP format validation (exactly 6 digits)
Session destroyed if 2FA verification fails
Uses authenticated session username to prevent bypass attacks
origin repo https://github.com/Tokisaki-Galaxy/luci-app-2fa