Skip to content

Conversation

@sion-111
Copy link

This change adds a speed selection field to device settings in LuCI.

Available speeds are populated dynamically using network.device status
via RPC, while still allowing manual custom values to be entered.

ACL permissions were extended to allow read-only access to
network.device status.

Tested on Banana Pi BPI-R4.

  • This PR is not from my main or master branch, but a separate branch
  • Each commit has a valid Signed-off-by: sion-111 <s.piotrowski91@gmail.com>
  • Each commit and PR title has a valid <package name>: title first line subject
  • Incremented any PKG_VERSION in the Makefile (not applicable)
  • Tested on: Banana Pi BPI-R4
  • Screenshot or mp4 of changes

Add speed choices populated from rpc device status while still allowing
manual custom values to be entered.

Signed-off-by: sion-111 <s.piotrowski91@gmail.com>
@github-actions
Copy link

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit 0a4e7b3

  • 🔶 Author name (sion-111) seems to be a nickname or an alias
  • 🔶 Committer name (sion-111) seems to be a nickname or an alias
  • 🔶 Commit subject length: recommended max 50, required max 60 characters

For more details, see the full job log.

Something broken? Consider providing feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant