Skip to content

cjson: bump minimum cmake version to 3.10#27617

Merged
champtar merged 1 commit intoopenwrt:masterfrom
champtar:cjson-cmake-4
Oct 7, 2025
Merged

cjson: bump minimum cmake version to 3.10#27617
champtar merged 1 commit intoopenwrt:masterfrom
champtar:cjson-cmake-4

Conversation

@champtar
Copy link
Member

@champtar champtar commented Oct 7, 2025

📦 Package Details

Maintainer: @karlp

Description:
Starting cmake 4.0, anything under 3.5 produces an error, see https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-version

Use a patch instead of CMAKE_OPTIONS so we don't forget to remove this hack.

upstream issue: DaveGamble/cJSON#935
related to #27607

🧪 Run Testing Details

NONE

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

Starting cmake 4.0, anything under 3.5 produces an error, see
https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-version

Use a patch instead of CMAKE_OPTIONS so we don't forget to remove this hack.

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
@champtar champtar merged commit f09845f into openwrt:master Oct 7, 2025
13 checks passed
@champtar champtar deleted the cjson-cmake-4 branch October 7, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants