treewide: musl-fts is only needed when using MUSL#29752
Open
pprindeville wants to merge 1 commit into
Open
Conversation
Two packages (fluent-bit and nnn) don't properly gate musl-fts as only required when using MUSL. Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
pprindeville
requested review from
Ansuel,
BKPepe,
GeorgeSapkin,
aparcar and
diizzyy
Member
Author
|
@GeorgeSapkin: Can I go ahead and merge this? Still not sure why some platforms always fail and others always succeed... Is it still the |
Member
fluent-bit segfaults in CI tests 1:
Not all platforms run these tests. Footnotes |
Member
Author
|
@GeorgeSapkin: Thanks. Is there an overview on checking out the tests and running them locally in your cloning? |
pprindeville
force-pushed
the
fix-musl-fts-dependencies
branch
2 times, most recently
from
72fde97 to
13f2693
Compare
Member
Author
|
Unmodified the package is segfaulting, so this is unrelated to my changes. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @BKPepe
Description:
Two packages (
fluent-bitandnnn) don't properly gatemusl-ftsas only required when using MUSL.🧪 Run Testing Details
✅ Formalities