Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

(server) Expose content URL on CR status#168

Merged
joelanford merged 1 commit intooperator-framework:mainfrom
anik120:url-in-status
Sep 18, 2023
Merged

(server) Expose content URL on CR status#168
joelanford merged 1 commit intooperator-framework:mainfrom
anik120:url-in-status

Conversation

@anik120
Copy link
Copy Markdown
Member

@anik120 anik120 commented Sep 14, 2023

closes #119

@anik120 anik120 requested a review from a team as a code owner September 14, 2023 14:15
@anik120 anik120 self-assigned this Sep 14, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.97% ⚠️

Comparison is base (21ba18e) 86.50% compared to head (93d07ac) 79.54%.

❗ Current head 93d07ac differs from pull request most recent head 4e31082. Consider uploading reports for the commit 4e31082 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   86.50%   79.54%   -6.97%     
==========================================
  Files           3        3              
  Lines         126      220      +94     
==========================================
+ Hits          109      175      +66     
- Misses         10       28      +18     
- Partials        7       17      +10     
Files Changed Coverage Δ
pkg/controllers/core/catalog_controller.go 81.72% <100.00%> (-11.83%) ⬇️
pkg/storage/localdir.go 65.62% <100.00%> (+1.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have them now, could you also update the docs in https://github.com/operator-framework/catalogd/blob/main/docs/fetching-catalog-contents.md ?

@anik120 anik120 force-pushed the url-in-status branch 4 times, most recently from e943249 to 93d07ac Compare September 15, 2023 14:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2023
closes operator-framework#119

Signed-off-by: Anik <anikbhattacharya93@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@joelanford joelanford added this pull request to the merge queue Sep 18, 2023
Merged via the queue into operator-framework:main with commit 20d83c1 Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Catalog.Status to include the URL to fetch catalog content from

6 participants