This repository was archived by the owner on Mar 3, 2025. It is now read-only.
🐛 Fix XDG_DATA_HOME build issue#264
Merged
everettraven merged 1 commit intooperator-framework:mainfrom May 23, 2024
Merged
Conversation
This mirrors the same fix made previously in operator-controller: operator-framework/operator-controller#790 Signed-off-by: Tayler Geiger <tayler@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 48.84% 48.84%
=======================================
Files 8 8
Lines 434 434
=======================================
Hits 212 212
Misses 201 201
Partials 21 21 ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
May 23, 2024
Collaborator
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
LGTM - thanks @trgeiger ! Apologies for the delayed review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the same fix made previously in operator-controller: operator-framework/operator-controller#790
That same fix was updated/fixed here: operator-framework/operator-controller#804
This PR reflects the latter, fixed version.