🐛 Fix matchConditions to be compatible with GenerateName

[tmshort]

This makes sure we have a name for the resource... the only way this could happen is if generateName is in use. In that case, k8s will update the resource with a name, and we'll catch it in the webhook after that happens.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.95%. Comparing base (6584e7e) to head (49e6d43).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   33.95%   33.95%           
=======================================
  Files          16       16           
  Lines         698      698           
=======================================
  Hits          237      237           
  Misses        435      435           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[grokspawn]

Is there a way to put some comments around that to make the precedence clear? I initially miscounted the perens and thought that you hadn't contained the existing conditions when adding the new stuff.

[grokspawn]

e2e failure looks legit

[tmshort]

It seems to be a timing issue, it passed on a re-run.

[joelanford]

Would reinvocationPolicy in the webhook config help?

I assume if the webhook is reinvoked, metadata.name would be available the second time because the name generator is another admission plugin.

[tmshort]

Yes, when k8s creates the name, it goes back through the webhook