-
Notifications
You must be signed in to change notification settings - Fork 73
Reconciler does not correctly handle UNSAT resolutions #330
Copy link
Copy link
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Milestone
Description
Related to operator-framework/deppy#139 and possibly #329
In Reconcile we:
- Check to see if
Solvereturned an error.- This currently can happen if a variable source returns an error when getting variables.
- Notably, solve does NOT return an error for UNSAT. This error means "was not able to get variables or setup the solver"
- Look for the matching variable in the solution
We skip the step of checking if the solution was SAT or UNSAT. UNSAT currently manifests as an error looking up the bundle entity from the solution. This "works", but it means users don't see the UNSAT reason that comes from solution.Error()
We should check solution.Error(), and handle it accordingly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.