Skip to content

🐛 Update catalogd Makefile#1659

Merged
joelanford merged 1 commit intooperator-framework:mainfrom
LalatenduMohanty:1604_update_catalogd_makefile
Jan 28, 2025
Merged

🐛 Update catalogd Makefile#1659
joelanford merged 1 commit intooperator-framework:mainfrom
LalatenduMohanty:1604_update_catalogd_makefile

Conversation

@LalatenduMohanty
Copy link
Copy Markdown
Member

@LalatenduMohanty LalatenduMohanty commented Jan 28, 2025

Updating the make file to use operator-controller/releases/latest/download/install.sh
Fixes #1604

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner January 28, 2025 17:58
Updating the make file to use operator-controller/releases/latest/download/install.sh
Fixes operator-framework#1604

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 28, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 3a8087a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67991b0a2779b50008f26d39
😎 Deploy Preview https://deploy-preview-1659--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LalatenduMohanty LalatenduMohanty force-pushed the 1604_update_catalogd_makefile branch from b1d3bb5 to 3a8087a Compare January 28, 2025 17:59
@LalatenduMohanty LalatenduMohanty changed the title 🐛 Update catalogd Makefile 🐛 Issue #1604: Update catalogd Makefile Jan 28, 2025
@LalatenduMohanty LalatenduMohanty changed the title 🐛 Issue #1604: Update catalogd Makefile 🐛 Update catalogd Makefile Jan 28, 2025
@dtfranz
Copy link
Copy Markdown
Contributor

dtfranz commented Jan 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
Copy link
Copy Markdown
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.42%. Comparing base (e667390) to head (3a8087a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1659   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files          55       55           
  Lines        4632     4632           
=======================================
  Hits         3123     3123           
  Misses       1284     1284           
  Partials      225      225           
Flag Coverage Δ
e2e 53.29% <ø> (ø)
unit 54.44% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Jan 28, 2025
Merged via the queue into operator-framework:main with commit f055efc Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Target run-latest-release in Makefile in the Catalog

4 participants