🐛 Fix webhook cert duplicate volume mount path bug

[perdasilva]

Description

1. Removes the APIService volume mount - since we don't yet support APIServices (let's avoid adding things that aren't needed yet)
2. Moves the tls.crt and tls.key magic strings to constants
3. Addresses the following bug:

When installing the Red Hat Network Observability operator, we were faced with the following error:

"error for resolved bundle \"network-observability-operator.v1.7.0\" with version \"1.7.0\": failed to create resource: Deployment.apps \"netobserv-controller-manager\" is invalid: spec.template.spec.containers[0].volumeMounts[2].mountPath: Invalid value: \"/tmp/k8s-webhook-server/serving-certs\": must be unique",

The root cause is related to the operator's Deployment's Pod template spec described in the CSV that included a volume mount pointing to the webhook certificate volume mount path (but had a different name than 'webhook-cert'):

volumeMounts:
- mountPath: /tmp/k8s-webhook-server/serving-certs
  name: cert
  readOnly: true

This PR updates the bundle deployment generator to replace any volume/mount referencing a protected path with the OLM generated values.

Before fixes, OLMv1 generated a deployment like:

volumeMounts:
- mountPath: /tmp/k8s-webhook-server/serving-certs
  name: cert
- mountPath: /etc/tls/private
  name: manager-metric-tls
  readOnly: true
- mountPath: /apiserver.local.config/certificates
  name: apiservice-cert
- mountPath: /tmp/k8s-webhook-server/serving-certs
  name: webhook-cert

volumes:
- name: cert
  secret:
    defaultMode: 420
    secretName: webhook-server-cert
- name: manager-metric-tls
  secret:
    defaultMode: 420
    secretName: manager-metrics-tls
- name: apiservice-cert
  secret:
    items:
    - key: tls.crt
      path: apiserver.crt
    - key: tls.key
      path: apiserver.key
    secretName: netobserv-controller-manager-service-cert
- name: webhook-cert
  secret:
    items:
    - key: tls.crt
      path: tls.crt
    - key: tls.key
      path: tls.key
    secretName: netobserv-controller-manager-service-cert

Now, it looks like:

volumeMounts:
- mountPath: /etc/tls/private
  name: manager-metric-tls
  readOnly: true
- mountPath: /tmp/k8s-webhook-server/serving-certs
  name: webhook-cert

volumes:
- name: manager-metric-tls
  secret:
    defaultMode: 420
    secretName: manager-metrics-tls
- name: webhook-cert
  secret:
    items:
    - key: tls.crt
      path: tls.crt
    - key: tls.key
      path: tls.key
    secretName: netobserv-controller-manager-service-cert

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	91dc9a1
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/683d8aad1924f40008794ad1
😎 Deploy Preview	https://deploy-preview-2002--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[camilamacedo86]

It really make sense 👍

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (d41ddd0) to head (91dc9a1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2002   +/-   ##
=======================================
  Coverage   69.17%   69.17%           
=======================================
  Files          79       79           
  Lines        7027     7037   +10     
=======================================
+ Hits         4861     4868    +7     
- Misses       1885     1887    +2     
- Partials      281      282    +1     

Flag	Coverage Δ
e2e	43.00% <0.00%> (-0.14%)	⬇️
unit	60.05% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.