🐛 When generating, delete only upstream targets#2098
🐛 When generating, delete only upstream targets#2098tmshort merged 1 commit intooperator-framework:mainfrom
Conversation
Using `find .` will delete all files of the name, this has a wide blast radius downstream. Limit the set of `find` directories to those in upstream. Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2098 +/- ##
==========================================
- Coverage 73.49% 73.45% -0.05%
==========================================
Files 78 78
Lines 7240 7240
==========================================
- Hits 5321 5318 -3
- Misses 1567 1569 +2
- Partials 352 353 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using
find .will delete all files of the name, this has a wide blast radius downstream. Limit the set offinddirectories to those in upstream.#2091 breaks downstream, this reduces the blast radius.
Description
Reviewer Checklist