Skip to content

🌱 Bump boxcutter to v0.13.0#2617

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
dtfranz:boxcutter-bump
Apr 1, 2026
Merged

🌱 Bump boxcutter to v0.13.0#2617
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
dtfranz:boxcutter-bump

Conversation

@dtfranz
Copy link
Copy Markdown
Contributor

@dtfranz dtfranz commented Apr 1, 2026

Bumps boxcutter to latest version which now contains the FieldValue probe, which allows us to remove it from our codebase.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Bumps boxcutter to latest version which now contains the FieldValue probe, which allows us to remove it from our codebase.

Signed-off-by: Daniel Franz <dfranz@redhat.com>
Copilot AI review requested due to automatic review settings April 1, 2026 00:55
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit fced86d
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69cc6d1004882700086e338a
😎 Deploy Preview https://deploy-preview-2617--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the boxcutter dependency to v0.13.0, which now provides the FieldValueProbe implementation. As a result, the custom implementation of FieldValueProbe and its tests are removed from the codebase, with usage updated to delegate to boxcutter's provided implementation.

Changes:

  • Updated boxcutter dependency from v0.12.0 to v0.13.0 in go.mod and go.sum
  • Removed the custom FieldValueProbe struct and its implementation methods from internal/operator-controller/applier/phase.go
  • Updated internal/operator-controller/controllers/clusterobjectset_controller.go to use probing.FieldValueProbe (from boxcutter) instead of applier.FieldValueProbe
  • Removed unused imports and the corresponding tests from internal/operator-controller/applier/phase_test.go

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Bumped boxcutter dependency to v0.13.0
go.sum Updated checksum for boxcutter v0.13.0
internal/operator-controller/controllers/clusterobjectset_controller.go Changed FieldValueProbe call from applier to probing package, removed applier import
internal/operator-controller/applier/phase.go Removed FieldValueProbe struct implementation and related unused imports
internal/operator-controller/applier/phase_test.go Removed Test_FieldValueProbe test and unused test imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.86%. Comparing base (ba1e4cb) to head (fced86d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2617   +/-   ##
=======================================
  Coverage   68.85%   68.86%           
=======================================
  Files         139      139           
  Lines        9931     9902   -29     
=======================================
- Hits         6838     6819   -19     
+ Misses       2578     2572    -6     
+ Partials      515      511    -4     
Flag Coverage Δ
e2e 37.54% <0.00%> (+0.01%) ⬆️
experimental-e2e 52.24% <100.00%> (-0.12%) ⬇️
unit 53.54% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you 🎉

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
Copy link
Copy Markdown
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c304741 into operator-framework:main Apr 1, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants