🐛 Update test to use proper step pattern.#2619
🐛 Update test to use proper step pattern.#2619openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
Found by CodeRabbit:
Line 625 has an undefined step: `${TEST_NAMESPACE}` does not match the registered
step pattern.
The step definition for "with needed permissions" is registered only for the
literal in test namespace pattern (verified in test/e2e/steps/steps.go line 128).
Line 625 uses `in ${TEST_NAMESPACE}`, which will cause the e2e test to fail with
an undefined step error. Update it to match the registered pattern.
Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Fixes an E2E Gherkin step that was not matching any registered step definition, which would cause an “undefined step” failure at runtime.
Changes:
- Replaces a step using
${TEST_NAMESPACE}with the literal phrasetest namespaceto match the existing step pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2619 +/- ##
==========================================
+ Coverage 68.86% 68.88% +0.02%
==========================================
Files 139 139
Lines 9902 9902
==========================================
+ Hits 6819 6821 +2
+ Misses 2572 2571 -1
+ Partials 511 510 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit f7f0352
into
operator-framework:main
Found by CodeRabbit:
Line 625 has an undefined step:
${TEST_NAMESPACE}does not match the registered step pattern.The step definition for "with needed permissions" is registered only for the literal in test namespace pattern (verified in test/e2e/steps/steps.go line 128). Line 625 uses
in ${TEST_NAMESPACE}, which will cause the e2e test to fail with an undefined step error. Update it to match the registered pattern.Description
Reviewer Checklist