fix: primary-resouce is created in wrong place.#6872
Merged
acornett21 merged 1 commit intooperator-framework:masterfrom Jan 16, 2025
Merged
fix: primary-resouce is created in wrong place.#6872acornett21 merged 1 commit intooperator-framework:masterfrom
acornett21 merged 1 commit intooperator-framework:masterfrom
Conversation
5169f1a to
2bd92d1
Compare
2bd92d1 to
8fcbc85
Compare
Contributor
Author
|
Hi @rashmigottipati @oceanc80 , I wonder if any of you have time to check my PR? Thanks a lot. |
Contributor
Author
|
Hi @rashmigottipati @oceanc80 , please advise how to proceed in order for this PR to be merged. I will appreciate it. |
Contributor
|
@holyspectral Can you rebase your PR since there are failing tests? |
When deployed with helm-operator, the primary custom resource would randomly get assigned "operator-sdk/primary-resource" and "operator-sdk/primary-resource-type" annotations. This commit fixes the issue. Signed-off-by: Sam Wang (holyspectral) <sam.wang@suse.com>
8fcbc85 to
0046acb
Compare
Contributor
Author
|
@acornett21 thanks! I've rebased my PR, but the sanity/sanity still fails due to |
acornett21
approved these changes
Jan 16, 2025
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR fixes the issue where the primary custom resource would randomly get assigned "operator-sdk/primary-resource" and "operator-sdk/primary-resource-type" annotations when helm-operator is used.
Motivation for the change:
We use helm operator to deploy our software in OpenShift environment. However, our primary custom resource would get random annotations assigned , e.g.,
The resource name and resource type would change randomly after each deployment.
After some debugging, it looks like
handler.SetOwnerAnnotations()'s arguments are in reverse.The caller:
The function:
This PR fixes the issue by correcting the order of arguments.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs