[#522] 로그아웃 시 미등록 FCM 토큰 삭제 실패로 로그아웃이 중단되는 문제를 해결한다#523
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트에서는 새로운 App.xcconfig 설정 파일을 추가하고, 프로젝트 설정(Project.swift 및 Xcode 프로젝트 파일)을 업데이트하여 APS_ENVIRONMENT 빌드 설정을 개발(development) 및 운영(production) 환경에 맞게 구성했습니다. 또한, LoginButton 뷰의 레이아웃 구조를 개선하였습니다. 리뷰 의견으로는 LoginButton에서 .contentShape(.capsule)을 버튼 외부에 적용할 경우 투명한 영역에서 터치 제스처가 정상적으로 감지되지 않을 수 있으므로, 이를 버튼 label 내부의 Text 뷰 뒤로 이동할 것을 제안합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
App.xcconfig를 추가해 로컬Config.xcconfig값을 Info.plist 치환에 사용🔍 상세
APS_ENVIRONMENT를 Debug는development, Release는production으로 설정Application/DevLogApp/Sources/App.xcconfig에서 공통 version 설정과 로컬 config 설정을 함께 include.gitignore대상인Config.xcconfig는 optional include로 처리해 CI 환경에서 파일 누락으로 인한 설정 로드 실패 방지APP_REDIRECT_URL,GITHUB_CLIENT_ID,GIDClientID, URL scheme 치환 확인aps-environment = development반영 확인LoginButton의 frame/overlay를 label 내부로 이동해 버튼 전체 영역이 탭되도록 수정📸 영상 / 이미지 (Optional)