[#519] List row들의 터치/탭 히트박스를 확장한다#525
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트에서는 HomeView.swift에서 .padding(.vertical, -6)과 .contentShape(.rect)의 적용 순서가 변경되었습니다. 리뷰어는 이러한 순서 변경과 음수 패딩의 사용이 터치 영역(hit-test area)의 중첩을 유발하여 오작동을 일으킬 수 있음을 지적하고, 대신 .listRowInsets를 사용하여 간격을 조절하도록 권장하는 유용한 피드백을 제공했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
contentShape적용 위치를 조정🔍 상세
labelImage에서 vertical padding보다 먼저contentShape(.rect)가 적용되도록 modifier 순서를 변경📸 영상 / 이미지 (Optional)