Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made Telegram CameraController support both camera1 and camera2, that brings camera2 features to the Telegram app.
Added Camera2 support in Camera2Controller class for all use cases like camera previews, photo captures, video records and instant video capture. Code for Camera2 follows the same style as the existing code base.
Added an interface and a fabric class CameraController that decides which camera API to use on a given device.
The original CameraController is kept intact, except for adding the interface implementation and renaming to Camera1Controller,
so minimal changes added in original code => no bugs added for Camera1 usage, ensuring backward compatibility with Android 4.x -6.0 and devices, which don't support Camera2 API.