docs: update query benchmarks (3.5.0)#684
Conversation
Greptile SummaryThis automated PR appends the 3.5.0 query benchmark data to Key changes:
No issues were found. The document follows all precedents set by the 3.4.1 and 3.4.0 notes. Confidence Score: 5/5Safe to merge — automated documentation update with consistent data across all representations and proper explanatory notes. All three data representations (summary table, detailed results section, and embedded JSON) are internally consistent. Percentage deltas are arithmetically correct. The native: null situation is fully explained in the new Note (3.5.0), which follows the established convention used for 3.4.1 and 3.4.0. No code is changed, only generated benchmark documentation. No P0 or P1 issues found. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant CI as GitHub Actions (Run #521)
participant NE as Native Engine (Rust)
participant WE as WASM Engine
participant BG as Benchmark Generator
participant DOC as QUERY-BENCHMARKS.md
CI->>NE: Build graph (insertNodes)
NE--xCI: CRASH — napi-rs serialization error (InsertNodesDefinition.visibility: null)
Note over NE: native: null
CI->>WE: Build graph (insertNodes)
WE-->>CI: Graph built successfully
CI->>WE: Run query benchmarks (fnDeps d1/d3/d5, fnImpact, diffImpact)
WE-->>CI: Results (9.1ms / 9.1ms / 9ms / 3ms / 3.1ms / 3.1ms / 6.4ms)
CI->>BG: Emit benchmark JSON for v3.5.0
BG-->>CI: { version: "3.5.0", wasm: {...}, native: null }
CI->>DOC: Prepend summary table row (wasm only)
CI->>DOC: Replace "Latest results" section (WASM only, target mid=db)
CI->>DOC: Prepend Note (3.5.0) to NOTES block
CI->>DOC: Prepend JSON entry to QUERY_BENCHMARK_DATA block
DOC-->>CI: PR opened (this PR)
Reviews (3): Last reviewed commit: "docs: note mid-target change (noTests→db..." | Re-trigger Greptile |
| | diffImpact latency | 8.1ms | | ||
| | diffImpact affected functions | 0 | | ||
| | diffImpact affected files | 0 | | ||
| **Version:** 3.5.0 | **Date:** 2026-03-30 |
There was a problem hiding this comment.
Missing native benchmarks — consider adding a note
3.5.0 is the first release since at least 3.3.1 to have "native": null in the benchmark data. Every prior version (3.4.1, 3.4.0, 3.3.1, …) included both a native (Rust) and a WASM row. The document has a precedent of adding a <!-- NOTES_START --> note whenever something unusual affects comparability (see the existing notes for 3.4.1 and 3.4.0).
Without a note, readers who try to compare native query latency across releases will find the series silently broken at 3.5.0. If native benchmarks were intentionally skipped (e.g., the CI step was removed, native engine deprecated, or the runner environment changed), a brief note would preserve the document's self-contained interpretability.
There was a problem hiding this comment.
Already addressed in the file. Line 61 contains a <!-- NOTES_START --> note for 3.5.0 that explains the native engine crash (InsertNodesDefinition.visibility napi-rs serialization bug), states native: null, and notes that query latencies are not directly comparable to prior versions. This matches the existing convention used for 3.4.1 and 3.4.0 notes.
Adds the mid-query target change callout to the 3.5.0 note, consistent with the convention used in 3.4.1 and 3.4.0 notes.
|
Addressed the P2 suggestion from the Greptile summary: added the mid-query target change callout ( Regarding CI: the test failures are all caused by the |
Automated query benchmark update for 3.5.0 from workflow run #521.