-
Notifications
You must be signed in to change notification settings - Fork 4
docs: update query benchmarks (3.5.0) #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4f32299
docs: update query benchmarks (3.5.0)
github-actions[bot] 1e3d79f
docs: add v3.5.0 native-null note to query benchmarks
carlos-alm c585b0a
docs: note mid-target change (noTests→db) in 3.5.0 benchmark note
carlos-alm 1bdd919
Merge remote-tracking branch 'origin/main' into pr-684-fix
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.5.0 is the first release since at least 3.3.1 to have
"native": nullin the benchmark data. Every prior version (3.4.1, 3.4.0, 3.3.1, …) included both a native (Rust) and a WASM row. The document has a precedent of adding a<!-- NOTES_START -->note whenever something unusual affects comparability (see the existing notes for 3.4.1 and 3.4.0).Without a note, readers who try to compare native query latency across releases will find the series silently broken at 3.5.0. If native benchmarks were intentionally skipped (e.g., the CI step was removed, native engine deprecated, or the runner environment changed), a brief note would preserve the document's self-contained interpretability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already addressed in the file. Line 61 contains a
<!-- NOTES_START -->note for 3.5.0 that explains the native engine crash (InsertNodesDefinition.visibilitynapi-rs serialization bug), statesnative: null, and notes that query latencies are not directly comparable to prior versions. This matches the existing convention used for 3.4.1 and 3.4.0 notes.