-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: migrate integration tests to InMemoryRepository #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
07c75ab
docs: move 3.16 items to new Phase 5 (Runtime & Extensibility)
carlos-alm 2ee4803
refactor: migrate integration tests to InMemoryRepository
carlos-alm 15365f4
Merge branch 'main' into refactor/inmemory-integration-tests
carlos-alm e72e2c5
merge: resolve conflict with origin/main in ROADMAP.md
carlos-alm ff74ffb
fix: use instanceof SqliteRepository guard and validate openRepo opts
carlos-alm 214eac6
docs: add Phase 4 (Native Analysis Acceleration) to roadmap
carlos-alm d122f0d
merge: resolve conflict with origin/main in ROADMAP.md
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minConfidencesilently ignored for RepositoryWhen a
Repositoryis passed andminConfidenceis set, the filter is silently dropped —getCallEdges()returns all call edges regardless of confidence. This means callers likeviewer.jsandexport.jsthat passminConfidencewould get incorrect (unfiltered) graphs if they were ever migrated to use the Repository path.At minimum, a
warn()log would make this visible. Better would be to add agetCallEdgesAboveConfidence(min)method to theRepositorycontract, or post-filter the results:Note: this suggestion requires
getCallEdges()to include aconfidencefield in its return shape, which would need a small change toInMemoryRepository.getCallEdges()andSqliteRepository.getCallEdges().There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — when a Repository is passed and
minConfidenceis set, call edges are now post-filtered in JS:.filter(e => e.confidence != null && e.confidence >= minConfidence). UpdatedgetCallEdges()in all three layers (SqliteRepository, InMemoryRepository, base JSDoc) to include theconfidencefield in the return shape.