-
Notifications
You must be signed in to change notification settings - Fork 4
fix(parity): restore call AST node extraction in WASM engine #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0efea90
refactor(extractors): add parser abstraction layer (Phase 7.1)
carlos-alm e3ae9b3
fix: address Greptile review comments (#700)
carlos-alm 1d296e8
fix: revert subpath imports to relative imports in builder stages
carlos-alm d0b578d
Merge remote-tracking branch 'origin/main' into refactor/parser-abstr…
carlos-alm 21d45cc
fix(parity): restore call AST node extraction in WASM engine (#697)
carlos-alm 5f1a74a
Merge branch 'main' into refactor/parser-abstraction-layer
carlos-alm 907bdf8
Merge branch 'main' into refactor/parser-abstraction-layer
carlos-alm 173ab12
fix: make enterNode skipChildren guard unconditional for matched node…
carlos-alm 56ef0ca
fix: pin exact call node count in ast-nodes test (#705)
carlos-alm 0f4259e
fix: revert enterNode skipChildren guard — node.id reuse causes false…
carlos-alm ed45a5b
ci: retry CI run (#705)
carlos-alm 36bc2aa
fix: add diagnostic logging for ast_nodes parity failure (#705)
carlos-alm 92d1592
ci: add diagnostic logging to trace WASM ast_nodes CI failure (#705)
carlos-alm 8a485a8
ci: expand diagnostic logging to trace buildAstNodes path (#705)
carlos-alm f2bab12
Merge remote-tracking branch 'origin/main' into refactor/parser-abstr…
carlos-alm 2a6c71d
fix: coerce null receiver to empty string for NAPI compat (#705)
carlos-alm afc2ec1
fix: remove parity-diag console.error logging (#705)
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#-alias imports to relative pathsbuild-edges.ts,build-structure.ts, andcollect-files.tsall have their#infrastructure/…,#db/…,#shared/…, and#typesimports converted to../../../../…relative paths. This change isn't mentioned in the PR description and isn't consistent with how the rest of the codebase uses these path aliases (e.g.pipeline.tsand other stage files still use the#-aliases).If this was done to fix a broken alias in a specific build or test context, a brief comment or follow-up ticket would help. If it was accidental, it should be reverted so import style stays uniform.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigated — the
#-alias to relative-path conversion is actually consistent with the rest of the stage files. On main,finalize.ts,detect-changes.ts,resolve-imports.ts,insert-nodes.ts,parse-files.ts, andrun-analyses.tsalready use relative paths. Onlybuild-edges.ts,build-structure.ts, andcollect-files.tsstill had the#-aliases. This PR normalizes the remaining 3 files to match the convention used by the other 6 stage files. No revert needed.