Improve subsolver BNTR#328
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 90.85% 90.70% -0.16%
==========================================
Files 171 173 +2
Lines 12439 12825 +386
==========================================
+ Hits 11302 11633 +331
- Misses 1137 1192 +55
Continue to review full report at Codecov.
|
segsell
commented
May 16, 2022
janosg
reviewed
May 17, 2022
segsell
commented
May 18, 2022
janosg
reviewed
May 19, 2022
janosg
reviewed
May 19, 2022
janosg
approved these changes
May 20, 2022
janosg
left a comment
Member
There was a problem hiding this comment.
Thanks a lot! This is very important for pounders and tranquilo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we improve the conjugate gradient step of the BNTR (Bounded Newton Trust-Region) algorithm by adding two conjugate gradient methods.
Previously, the only available option was an off-the-shelf conjugate gradient implementation.
The new methods are:
The respective flags for our three methods are:
TRSBOX performs best on the
more_wildbenchmark set and is thus the recommended default.