Skip to content

fix(cli): align fail-on defaults#25

Open
nvphungdev wants to merge 1 commit into
optiqor:mainfrom
nvphungdev:fix/fail-on-default-parity
Open

fix(cli): align fail-on defaults#25
nvphungdev wants to merge 1 commit into
optiqor:mainfrom
nvphungdev:fix/fail-on-default-parity

Conversation

@nvphungdev
Copy link
Copy Markdown

What

Align audit --fail-on with analyze --fail-on so both commands require an explicit threshold before returning exit code 1 for findings.

Why

Fixes #22

How

Changed the audit command default from high to unset, added a regression test that runs audit without --fail-on, and updated the README flag table to document the opt-in default.

Testing

  • golangci-lint run passes in Docker via golangci/golangci-lint:latest
  • go test ./... passes in Docker via golang:1.24
  • go test -race ./... passes in Docker via golang:1.24
  • go vet ./... passes in Docker via golang:1.24
  • Tested locally with: docker run --rm -v "$PWD":/src -w /src golang:1.24 go test -race ./...

Checklist

  • PR title follows Conventional Commits (feat(scope): subject)
  • All commits are DCO-signed
  • No unrelated changes pulled in
  • Documentation updated where user-visible behavior changed
  • No LLM calls or telemetry introduced
  • No proprietary backend imports

@nvphungdev nvphungdev requested a review from btwshivam as a code owner May 17, 2026 02:13
@github-actions
Copy link
Copy Markdown

First PR — welcome aboard!

A few things to expect:

  1. CI: every PR runs build + race tests + lint on Ubuntu and macOS. If something fails, the log will tell you exactly which gate.
  2. DCO: every commit needs Signed-off-by:. git commit -s adds it automatically.
  3. Conventional Commits: PR titles like feat(analyze): new rule or fix(cli): handle X. We squash-merge by default.
  4. Review: a maintainer will review within 72 hours. Suggestions are conversations, not orders — push back if something doesn't fit your context.

If you get stuck, reply here or jump to Discussions. We want this PR to land.

@github-actions github-actions Bot added documentation Improvements or additions to documentation testing Test coverage and golden fixtures area/cli Cobra CLI commands and UX size/S 11–50 lines labels May 17, 2026
Signed-off-by: nvphungdev <283886185+nvphungdev@users.noreply.github.com>
@nvphungdev nvphungdev force-pushed the fix/fail-on-default-parity branch from 2deff7f to 19e4ffd Compare May 18, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Cobra CLI commands and UX documentation Improvements or additions to documentation size/S 11–50 lines testing Test coverage and golden fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): align audit and analyze --fail-on defaults

1 participant