fix(npm): fail postinstall when binary download fails#31
Open
akmhatey-ai wants to merge 2 commits into
Open
Conversation
Signed-off-by: akmhatey-ai <260399619+akmhatey-ai@users.noreply.github.com>
|
First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postinstallfail with exit code 1 when the release binary download fails.Fixes #26.
Validation
node --check npm/postinstall.jsnode --check npm/postinstall.test.jsnpm run test:postinstallnpm pack --dry-rungit diff --checkgit diff --cached --checkgit diff --cached | gitleaks detect --pipe --redact --verbose --no-colorNotes
go test ./...is blocked by upstream vendor metadata, andgo test -mod=mod ./...fails in existingcmd/optiqorgolden output path-separator expectations unrelated to this change.