test: Add test on skip heights in CBlockIndex#14
Draft
optout21 wants to merge 1 commit into
Draft
Conversation
optout21
force-pushed
the
skip-height-test4
branch
2 times, most recently
from
May 19, 2026 08:00
1415e29 to
6bd2a1b
Compare
Add new test that calls `CBlockIndex::BuildSkip()` and verifies skip height values. It tests that: - `pprev` field is set (to an earlier block index), - the skip is to the index as dictated by the `GetSkipHeight()` bit-manipulation logic.
optout21
force-pushed
the
skip-height-test4
branch
from
May 19, 2026 15:13
6bd2a1b to
1f13afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trial for bitcoin#33661
The skip height values computed by the (internal) function
GetSkipHeight(), and theCBlockIndex::BuildSkip()method are not tested directly, and the skip logic is not well documented. To improve test coverage, a new test is added, to verifyCBlockIndex::BuildSkip()and the skip height bit-manipulation logic.Note: the original version contained a test for the complexity of the
GetAncestor()algorithm, whose performance is greatly determined by the skip height logic. This test was out-scoped.The motivation is to document the skip value computation through a test. (The issued was noticed while reviewing bitcoin#33515.)