fix: keep gomega in go.sum across renovate updates#149
Merged
Conversation
`test/integration/{integration,operator}_test.go` import gomega behind
the `//go:build integration` tag. `go mod tidy` ignores tagged files,
so renovate-driven version bumps strip or omit gomega from go.sum,
breaking the integration job (e.g. PR #132).
Add a tag-free blank import in the same package so tidy keeps gomega
tracked. The file has no runtime impact: under the integration tag it
sits next to the real users; without the tag it builds alone with
just the side-effect import.
peter-svensson
force-pushed
the
fix/integration-go-sum
branch
from
24330ec to
a4be83f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renovate-driven ginkgo and gomega bumps fail integration tests with
missing go.sum entry for module providing package github.com/onsi/...(see PR #131, #132). Root cause:
test/integration/{integration,operator}_test.goimport them behind
//go:build integration, butgo mod tidyignoresfiles behind custom build tags, so it strips or omits them from
go.sumduring the upgrade.
Fix: add a tag-free
deps_test.gowith blank imports of bothginkgo/v2and
gomegain the same package. Tidy now sees them from default buildsand keeps them tracked. No runtime impact — file builds alone (side-effect
imports only) without the tag, sits next to the real users with the tag.
Test plan
should pass without manual
go.sumediting