Fix flaky testGetSuggestionsMultipleProjects test #4891
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
gaborbernat
force-pushed
the
fix-flaky-suggester-test
branch
2 times, most recently
from
00953ae to
6b2d360
Compare
The test expected 4 suggestions including "meta" from the JAR's META-INF directory, but this indexing is inconsistent on macOS. Changed assertion to verify the 3 stable suggestions are present. Fixes oracle#2704 Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
vladak
force-pushed
the
fix-flaky-suggester-test
branch
from
6b2d360 to
b5d4aeb
Compare
Member
|
Thanks for the analysis and the fix, much appreciated as this has been hunting the test runs for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test expected 4 suggestions:
["me", "method", "message", "meta"]On macOS, it sometimes only returns 3:
["me", "message", "method"]- missing "meta".Where each suggestion comes from:
me- from Kotlin source: "me and I" in helloWorld.ktmethod- from Java identifiers:Method,InnerMethod,AbstractMethodin Sample.javamessage- from Java source codemeta- from JAR'sMETA-INF/directory path (main.jar contains META-INF/)The first 3 come from reliably indexed source code content. The 4th ("meta") comes from JAR path indexing, which appears to be inconsistent on macOS.
Evidence:
no item matches: "meta" in ["me", "message", "method"]meandmessageMETA-INF/directory which is the only source of "meta"Changed assertion to verify the 3 stable suggestions are present instead of requiring all 4.
Related to #2704
Ran into this while working on #4890