chore: update linting scope#1852
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
=======================================
Coverage 87.29% 87.29%
=======================================
Files 143 143
Lines 5535 5535
=======================================
Hits 4832 4832
Misses 417 417
Partials 286 286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c6dd18d to
9db28ed
Compare
|
codecov/patch is not useful here |
9db28ed to
3cb7f49
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces additional linting rules and configuration to improve code quality. The changes include setting up a comprehensive golangci-lint configuration file and applying various linting fixes throughout the codebase.
- Adds a comprehensive
.golangci.ymlconfiguration file with multiple linters enabled - Fixes import grouping and organization across multiple files
- Updates test helper functions to include
t.Helper()calls and simplifies temporary directory/file handling
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | New comprehensive linting configuration with multiple linters enabled |
| internal/testutils/fetcher.go | Adds blank line to separate import groups |
| internal/testutils/error_fetcher.go | Reorganizes imports with proper grouping |
| internal/io/tar_utils_test.go | Simplifies temp directory handling using t.TempDir() |
| cmd/oras/root/manifest/index/create_test.go | Adds t.Helper() calls to test helper functions |
| cmd/oras/root/cp_test.go | Replaces inline struct literal with variable assignment |
| cmd/oras/internal/option/packer_test.go | Adds t.Helper() call to test helper function |
| cmd/oras/internal/display/status/text_test.go | Adds t.Helper() call to test helper function |
| cmd/oras/internal/display/status/progress/status_test.go | Adds t.Helper() calls to test helper functions |
| cmd/oras/internal/display/status/console/console_test.go | Adds t.Helper() calls to test helper functions |
| cmd/oras/internal/display/metadata/descriptor/manifest_fetch.go | Reorganizes imports with proper grouping |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @TerryHowe, are we able to merge this PR? You may want to rebase it before merging. Thanks |
56a8e0c to
06e49fd
Compare
|
New problem was introduced, so I've had to update. |
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5341424 to
c9a7e61
Compare
What this PR does / why we need it:
Add some additional lint checks.