Adding stepsize as a parameter that can be passed to the model#66
Open
harivnkochi wants to merge 4 commits intoorg-arl:devfrom
Open
Adding stepsize as a parameter that can be passed to the model#66harivnkochi wants to merge 4 commits intoorg-arl:devfrom
harivnkochi wants to merge 4 commits intoorg-arl:devfrom
Conversation
Member
|
Uh, why is bubble resonance changes in this PR? |
Member
|
@harivnkochi still planning to follow up on this someday? |
Contributor
Author
|
Yes :-) . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes choosing a smaller step size helps propagation, because Bellhop's default stepsize (activated if you pass 0 to env file) is channeldepth/10. Currently the uwapm model does not accept stepsize as a parameter though it can be passed to bellhop.