This repository was archived by the owner on Jan 2, 2025. It is now read-only.
fix: correctly handle empty params#36
Merged
aeneasr merged 4 commits intoory:masterfrom Oct 11, 2021
kubuzetto:fix-empty-param-bug
Merged
fix: correctly handle empty params#36aeneasr merged 4 commits intoory:masterfrom kubuzetto:fix-empty-param-bug
aeneasr merged 4 commits intoory:masterfrom
kubuzetto:fix-empty-param-bug
Conversation
Signed-off-by: Devrim Şahin <devrim.sahin@picussecurity.com>
Signed-off-by: Devrim Şahin <devrim.sahin@picussecurity.com>
aeneasr
suggested changes
Oct 9, 2021
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Could you please extract this logic into a separate func and add tests for it? That should resolve future regressions like the one introduced in the previous PR
Contributor
Author
|
Sure thing 👍 Where do your unit tests normally reside? I cannot locate them. |
Signed-off-by: Devrim Şahin <devrim.sahin@picussecurity.com>
Member
|
We don't have them yet :( That's probably the root cause of missing the previous bug :) You can just add a new |
Contributor
Author
|
Ah ok 😄 Added a simple test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.