Skip to content

Drop unused sonic-yang-mgmt dependency - #2327

Merged
osfrickler merged 1 commit into
mainfrom
remove-sonic-yang-mgmt
Jun 2, 2026
Merged

Drop unused sonic-yang-mgmt dependency#2327
osfrickler merged 1 commit into
mainfrom
remove-sonic-yang-mgmt

Conversation

@berendt

@berendt berendt commented Jun 2, 2026

Copy link
Copy Markdown
Member

What

Removes the sonic-yang-mgmt git dependency from Pipfile and Pipfile.lock.

Why

sonic-yang-mgmt was added in #2191 for the original libyang-based SONiC config validator. #2253 replaced that validator with offline-generated Pydantic schemas and cleaned up requirements.txt, requirements.sonic.txt and the Containerfile — but left the dependency behind in Pipfile/Pipfile.lock.

Nothing imports sonic_yang_mgmt anymore:

  • the runtime validator depends only on pydantic (see osism/tasks/conductor/sonic/validator.py)
  • the schema generator (tools/sonic_yang_to_pydantic.py) uses pyang, which stays

It was also the only git dependency in the lockfile.

Notes

  • The Pipfile.lock _meta hash was recomputed with pipenv's own calculate_pipfile_hash() so the lockfile stays in sync with the Pipfile.
  • pyang is intentionally kept — it is required by the schema generator.

🤖 Generated with Claude Code

The sonic-yang-mgmt git dependency was added in #2191 for the original
libyang-based SONiC config validator. #2253 replaced that validator with
offline-generated Pydantic schemas and cleaned up requirements.txt,
requirements.sonic.txt and the Containerfile, but left the dependency
behind in Pipfile/Pipfile.lock.

Nothing imports sonic_yang_mgmt anymore (the runtime validator depends only
on pydantic, and the schema generator uses pyang), so remove it from both
files and refresh the Pipfile hash.

AI-assisted: Claude Code

Signed-off-by: Christian Berendt <berendt@osism.tech>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@berendt
berendt requested a review from osfrickler June 2, 2026 15:37
@osfrickler
osfrickler merged commit bf097ff into main Jun 2, 2026
4 checks passed
@osfrickler
osfrickler deleted the remove-sonic-yang-mgmt branch June 2, 2026 17:00
@github-project-automation github-project-automation Bot moved this from Ready to Done in Human Board Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants