Skip to content

Add unit tests for osism/utils/rabbitmq.py #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ideaship merged 2 commits into from
Jul 16, 2026
Merged

Add unit tests for osism/utils/rabbitmq.py #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88cb7be
Skip RabbitMQ hosts that fail address resolution
berendt Jul 16, 2026
83da5a2
Add unit tests for osism/utils/rabbitmq.py
berendt Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 76 additions & 68 deletions osism/utils/rabbitmq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,84 +40,92 @@ def get_rabbitmq_node_addresses():

node_addresses = []
for host in rabbitmq_hosts:
# Get ansible facts from Redis cache
facts_data = utils.redis.get(f"ansible_facts{host}")
if not facts_data:
logger.error(f"No ansible facts found in cache for {host}")
continue
# A failure on one host must not discard the addresses already
# collected for the other nodes.
try:
# Get ansible facts from Redis cache
facts_data = utils.redis.get(f"ansible_facts{host}")
if not facts_data:
logger.error(f"No ansible facts found in cache for {host}")
continue

facts = json.loads(facts_data)

# Get hostvars for this host to find internal_interface
hostvar_inventory_path = get_inventory_path(
"/ansible/inventory/hosts.yml", prefer_minified=False
)
result = subprocess.check_output(
f"ansible-inventory -i {hostvar_inventory_path} --host {host}",
shell=True,
stderr=subprocess.DEVNULL,
)
hostvars = json.loads(result)

internal_interface_raw = hostvars.get("internal_interface")
if not internal_interface_raw:
logger.error(f"internal_interface not found in hostvars for {host}")
continue
facts = json.loads(facts_data)

# Resolve Jinja2 template if present (e.g., "{{ ansible_local.testbed_network_devices.management }}")
internal_interface = internal_interface_raw
template_match = re.match(r"\{\{\s*(.+?)\s*\}\}", internal_interface_raw)
if template_match:
path = template_match.group(1).strip()
parts = path.split(".")
value = facts
for part in parts:
if isinstance(value, dict):
value = value.get(part)
else:
value = None
break
if value and isinstance(value, str):
internal_interface = value
else:
logger.error(
f"Could not resolve template '{internal_interface_raw}' from facts for {host}"
)
# Get hostvars for this host to find internal_interface
hostvar_inventory_path = get_inventory_path(
"/ansible/inventory/hosts.yml", prefer_minified=False
)
result = subprocess.check_output(
f"ansible-inventory -i {hostvar_inventory_path} --host {host}",
shell=True,
stderr=subprocess.DEVNULL,
)
hostvars = json.loads(result)

internal_interface_raw = hostvars.get("internal_interface")
if not internal_interface_raw:
logger.error(f"internal_interface not found in hostvars for {host}")
continue

logger.debug(f"Internal interface for {host}: {internal_interface}")
# Resolve Jinja2 template if present (e.g., "{{ ansible_local.testbed_network_devices.management }}")
internal_interface = internal_interface_raw
template_match = re.match(
r"\{\{\s*(.+?)\s*\}\}", internal_interface_raw
)
if template_match:
path = template_match.group(1).strip()
parts = path.split(".")
value = facts
for part in parts:
if isinstance(value, dict):
value = value.get(part)
else:
value = None
break
if value and isinstance(value, str):
internal_interface = value
else:
logger.error(
f"Could not resolve template '{internal_interface_raw}' from facts for {host}"
)
continue

# Look for the interface in ansible facts
# Interface names with special chars are normalized (e.g., eth0.100 -> ansible_eth0_100)
normalized_interface = internal_interface.replace(".", "_").replace(
"-", "_"
)
interface_key = f"ansible_{normalized_interface}"
logger.debug(f"Internal interface for {host}: {internal_interface}")

interface_facts = facts.get(interface_key)
if not interface_facts:
logger.error(
f"Interface {internal_interface} ({interface_key}) not found in ansible facts for {host}"
# Look for the interface in ansible facts
# Interface names with special chars are normalized (e.g., eth0.100 -> ansible_eth0_100)
normalized_interface = internal_interface.replace(".", "_").replace(
"-", "_"
)
continue
interface_key = f"ansible_{normalized_interface}"

# Get IPv4 address
ipv4_info = interface_facts.get("ipv4")
if not ipv4_info:
logger.error(
f"No IPv4 address found for interface {internal_interface} on {host}"
)
continue
interface_facts = facts.get(interface_key)
if not interface_facts:
logger.error(
f"Interface {internal_interface} ({interface_key}) not found in ansible facts for {host}"
)
continue

ipv4_address = ipv4_info.get("address")
if not ipv4_address:
logger.error(
f"No IPv4 address found for interface {internal_interface} on {host}"
)
continue
# Get IPv4 address
ipv4_info = interface_facts.get("ipv4")
if not ipv4_info:
logger.error(
f"No IPv4 address found for interface {internal_interface} on {host}"
)
continue

ipv4_address = ipv4_info.get("address")
if not ipv4_address:
logger.error(
f"No IPv4 address found for interface {internal_interface} on {host}"
)
continue

logger.debug(f"IPv4 address for {host}: {ipv4_address}")
node_addresses.append((ipv4_address, host))
logger.debug(f"IPv4 address for {host}: {ipv4_address}")
node_addresses.append((ipv4_address, host))
except Exception as exc:
logger.error(f"Failed to resolve address for {host}: {exc}")
continue

if not node_addresses:
logger.error("Could not retrieve address for any RabbitMQ node")
Expand Down
Loading