Skip to content

Add unit tests for osism/api.py HTTP and WebSocket endpoints #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ideaship merged 4 commits into from
Jul 23, 2026
Merged

Add unit tests for osism/api.py HTTP and WebSocket endpoints #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc84b99
Add unit tests for osism/api.py HTTP and WebSocket endpoints
berendt Jul 18, 2026
d890be2
Return 500 for unparsable inventory in hostvars endpoints
berendt Jul 23, 2026
6b801b9
Count only searched hosts in inventory search response
berendt Jul 23, 2026
ace2f71
Reject non-positive limit in inventory search endpoint
berendt Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions osism/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from fastapi import (
FastAPI,
Header,
Query,
Request,
Response,
HTTPException,
Expand Down Expand Up @@ -826,7 +827,7 @@ async def get_host_hostvars(host: str) -> HostvarsResponse:
)

if result.returncode != 0:
if "Unable to parse" in result.stderr or "Could not match" in result.stderr:
if "Could not match" in result.stderr:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail=f"Host '{host}' not found in inventory",
Expand Down Expand Up @@ -889,7 +890,7 @@ async def get_host_hostvar(host: str, variable: str) -> HostvarSingleResponse:
)

if result.returncode != 0:
if "Unable to parse" in result.stderr or "Could not match" in result.stderr:
if "Could not match" in result.stderr:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail=f"Host '{host}' not found in inventory",
Expand Down Expand Up @@ -1019,7 +1020,7 @@ async def search_inventory(
name_pattern: str,
host_pattern: Optional[str] = None,
source: Optional[str] = None,
limit: int = 100,
limit: int = Query(default=100, gt=0),
) -> SearchResponse:
"""Search for variables or facts across hosts using regex patterns.

Expand Down Expand Up @@ -1092,11 +1093,12 @@ async def search_inventory(
hosts_to_search = all_hosts

results: List[SearchResultEntry] = []
hosts_searched = len(hosts_to_search)
hosts_searched = 0

for host in hosts_to_search:
if len(results) >= limit:
break
hosts_searched += 1

# Search hostvars
if source in (None, "hostvars"):
Expand Down
Loading