perf!: Make slashing not write sign info every block (SDK: #19458)#543
Merged
czarcas7ic merged 8 commits intoosmo/v0.47.5from Mar 7, 2024
Merged
perf!: Make slashing not write sign info every block (SDK: #19458)#543czarcas7ic merged 8 commits intoosmo/v0.47.5from
czarcas7ic merged 8 commits intoosmo/v0.47.5from
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+51
to
+52
| panic(fmt.Errorf("invalid state, the validator %v has start height %d , which is greater than the current height %d (as parsed from the header)", | ||
| signInfo.Address, signInfo.StartHeight, height)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
Member
Author
|
I'll replay this PR after we get slashing SDK 50 backported |
Member
|
Replayed, merging |
czarcas7ic
added a commit
that referenced
this pull request
May 9, 2024
…) (#543) * perf!: Make slashing not write sign info every block (SDK: cosmos#19458) cosmos#19458 * change NewSignInfo API * Bring back String() change * Fix test * Another test fix that didn't get committed * merge conflict --------- Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cosmos#19458
Can someone help me with rebuilding the proto