Skip to content

x/gamm : Fix public/private on GetNextPoolNumber API#1987

Merged
ValarDragon merged 3 commits intomainfrom
dev/fix_get_next_pool_number_api
Jul 7, 2022
Merged

x/gamm : Fix public/private on GetNextPoolNumber API#1987
ValarDragon merged 3 commits intomainfrom
dev/fix_get_next_pool_number_api

Conversation

@ValarDragon
Copy link
Copy Markdown
Member

What is the purpose of the change

Break off from my simulator work -- Make & Use GetNexttPoolNumber API, make the increment and set API's internal.

This likely will fix some unreported edge cases with queries as well.

Brief Changelog

  • Remove public GetNextPoolNumberAndIncrement method in favor of GetNextPoolNumber

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not documented

@ValarDragon ValarDragon requested a review from a team July 7, 2022 03:51
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jul 7, 2022
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 7, 2022
Copy link
Copy Markdown
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants