Merged
Conversation
github-actions
bot
added
C:app-wiring
p0mvn
commented
Jul 21, 2022
|
|
||
| for _, test := range tests { | ||
| suite.SetupTest() | ||
| suite.Run(test.name, func() { |
Member
Author
There was a problem hiding this comment.
Note to reviewers: the diff is large because of indentation change due to suite.Run
p0mvn
added
A:backport/v11.x
czarcas7ic
approved these changes
Jul 29, 2022
x/gamm/keeper/msg_server_test.go
Outdated
| shareInAmount: sdk.NewInt(shareOut), | ||
| tokenOutMins: sdk.NewCoins(), | ||
| expectedRemoveLiquidityEvents: 1, | ||
| expectedMessageEvents: 3, // 1 gamm + 2 tendermint. |
Member
There was a problem hiding this comment.
just for my learning, why are there two TM messages emitted here?
Member
Author
There was a problem hiding this comment.
These are not TM, the comment is wrong, and I'm going to change this. This happens because other keeper methods emit these events. For example, bank send:
https://github.com/cosmos/cosmos-sdk/blob/71035879e4af4551b9bcf16f79bc52785793602e/x/bank/keeper/send.go#L213-L215
I think the bank send is wrong and should instead have its message emitted in the message server so that we don't triple-count it here.
Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Adam Tucker <adam@osmosis.team>
Member
Author
|
Planning on merging this once CI passes. All comments are addressed and no API or state-breaking changes |
alexanderbez
approved these changes
Aug 3, 2022
alexanderbez
reviewed
Aug 3, 2022
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
* test(x/gamm): remove liquidity events * remove capacity pre-allocation * Update x/gamm/keeper/internal/events/emit_test.go Co-authored-by: Adam Tucker <adam@osmosis.team> * Update x/gamm/keeper/msg_server_test.go Co-authored-by: Adam Tucker <adam@osmosis.team> * Update x/gamm/keeper/pool_service_test.go Co-authored-by: Adam Tucker <adam@osmosis.team> * shareIn * update event comments * changelog * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * add docs Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> (cherry picked from commit 40f19a3) # Conflicts: # CHANGELOG.md # x/gamm/keeper/pool_service_test.go # x/superfluid/keeper/unpool_test.go
p0mvn
added a commit
that referenced
this pull request
Aug 3, 2022
p0mvn
added a commit
that referenced
this pull request
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #1942
What is the purpose of the change
Tests remove liquidity events that should be emitted when a pool is exited.
Similarly to #2141, I noticed that they were emitted twice:
I removed 1. while keeping 2.
No breaking changes.
Passthrough changes
AssertEventEmittedtest helper to be defined on the suite. It is also useful for testing events in other modulesctxsuite.Run()to some table-driven testsTesting and Verifying
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no