Fix order for JoinSwapShareAmountOut CLI args

[rrrliu]

Closes: #3813

What is the purpose of the change

Swaps the token_in_max_amount and share_out_amount CLI arguments of JoinSwapShareAmountOut to match spec in docs.

Brief Changelog

• Swapped order of token_in_max_amount and share_out_amount in proto
• Autogenerated resulting proto files

Testing and Verifying

Based off the example that @larry0x provided in the issue, I rebuilt osmosisd locally and ran the following to verify:

$ build/osmosisd tx gamm join-swap-share-amount-out uosmo 12345 67890 --pool-id 678 --from test1 --chain-id 1

{"body":{"messages":[{"@type":"/osmosis.gamm.v1beta1.MsgJoinSwapShareAmountOut","sender":"osmo1cyyzpxplxdzkeea7kwsydadg87357qnahakaks","pool_id":"678","token_in_denom":"uosmo","token_in_max_amount":"12345","share_out_amount":"67890"}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[],"fee":{"amount":[],"gas_limit":"350000","payer":"","granter":""}},"signatures":[]}

confirm transaction before signing and broadcasting [y/N]: ^C  

As seen above, the token_in_max_amount being 12345 (the 2nd argument) and share_out_amount being 67890 (the 3rd argument) indicate that the order of the arguments is now fixed.

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes? bugfix
• Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
• How is the feature or change documented? gamm README

[ValarDragon]

No we can't edit the proto tx, should be editing the CLI code only.

[ValarDragon]

The relevant code that should be edited is here: https://github.com/osmosis-labs/osmosis/blob/main/x/gamm/client/cli/tx.go#L137-L144

Osmocli doesn't have tooling right for now letting you change the arg order. Either we add that, or we make a custom parse fn (likely much easier) for this CLI tx. (ParseAndBuildMsg, but use osmocli methods for parsing each arg)

[larry0x]

I think simply fixing the help text would be good enough.

Also, I suspect other CLI commands related to x/gamm may have the same issue, so better give them a test as well.

[rrrliu]

@ValarDragon thoughts on just changing the order of args on the usage text / README?

[ValarDragon]

Ah yeah, just changing the help text SGTM

[ValarDragon]

TYSM! Really appreciate the issue close :)

If you get a chance, would you be down to add a changelog entry to breaking changes in the ## v13.1.2 section for

* [3647](https://github.com/osmosis-labs/osmosis/pull/3647), [3942](https://github.com/osmosis-labs/osmosis/pull/3942) (CLI) re-order the command line arguments for `osmosisd tx gamm join-swap-share-amount-out`

[rrrliu]

TYSM! Really appreciate the issue close :)

If you get a chance, would you be down to add a changelog entry to breaking changes in the ## v13.1.2 section for

* [3647](https://github.com/osmosis-labs/osmosis/pull/3647), [3942](https://github.com/osmosis-labs/osmosis/pull/3942) (CLI) re-order the command line arguments for `osmosisd tx gamm join-swap-share-amount-out`

Added!

[ValarDragon]

Thank you!