Skip to content

refactor: unify pool query in pool manager, deprecate x/gamm, remove from CL module#4658

Merged
p0mvn merged 3 commits intomainfrom
roman/poolmanager-pool
Mar 17, 2023
Merged

refactor: unify pool query in pool manager, deprecate x/gamm, remove from CL module#4658
p0mvn merged 3 commits intomainfrom
roman/poolmanager-pool

Conversation

@p0mvn
Copy link
Copy Markdown
Member

@p0mvn p0mvn commented Mar 17, 2023

Closes: #XXX

What is the purpose of the change

This PR unifies the Pool query for balancer, stableswap and CL pools in the x/poolmanager module. It removes the corresponding query from the CL module as x/poolmanager should be the only correct entry point.

In x/gamm, it deprecates the corresponding query to maintain backward compatibility. The logic calls in the x/poolmanager keeper that now routes calls.

Simlar is done for the CLI.

Brief Changelog

  • implement Pool query in x/poolmanager
  • refactor x/gamm to call the pool manager's keeper
  • remove the query and CLI from `x/concentrated-liquidity

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@p0mvn p0mvn changed the title refactor: unify pool query in pool manager, deprecate x/gamm, remove … refactor: unify pool query in pool manager, deprecate x/gamm, remove from CL module Mar 17, 2023
@github-actions github-actions bot added C:CLI C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager labels Mar 17, 2023
@p0mvn p0mvn added the V:state/breaking State machine breaking PR label Mar 17, 2023
@p0mvn p0mvn marked this pull request as ready for review March 17, 2023 19:51
Copy link
Copy Markdown
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job getting this out so fast. I think we are good to merge to unblock frontend. All logic LGTM

Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:CLI C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager V:state/breaking State machine breaking PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants